Fix urlmap in ILB L7 module (#1299)

* port tests to new format

* add test to catch error and fix urlmap

* boilerplate

* boilerplate

modules/net-ilb-l7/urlmap.tf

@@ -545,9 +545,9 @@ resource "google_compute_region_url_map" "default" {
           }
           dynamic "url_redirect" {
             for_each = (
-              route_rules.value.default_url_redirect == null
+              route_rules.value.url_redirect == null
               ? []
-              : [route_rules.value.default_url_redirect]
+              : [route_rules.value.url_redirect]
             )
             content {
               host_redirect          = url_redirect.value.host

tests/modules/net_ilb_l7/common.tfvars

@@ -0,0 +1,23 @@
+/**
+ * Copyright 2023 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+project_id = "my-project"
+name       = "ilb-l7-test"
+region     = "europe-west1"
+vpc_config = {
+  network    = "projects/my-project/global/networks/default"
+  subnetwork = "projects/my-project/regions/europe-west1/subnetworks/default"
+}

tests/modules/net_ilb_l7/defaults.tfvars

@@ -0,0 +1,23 @@
+/**
+ * Copyright 2023 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+backend_service_configs = {
+  default = {
+    backends = [{
+      group = "projects/myprj/zones/europe-west1-a/instanceGroups/my-ig"
+    }]
+  }
+}

tests/modules/net_ilb_l7/defaults.yaml

@@ -0,0 +1,20 @@
+# Copyright 2023 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+counts:
+  google_compute_forwarding_rule: 1
+  google_compute_health_check: 1
+  google_compute_region_backend_service: 1
+  google_compute_region_target_http_proxy: 1
+  google_compute_region_url_map: 1

tests/modules/net_ilb_l7/groups.tfvars

@@ -0,0 +1,32 @@
+/**
+ * Copyright 2023 Google LLC
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+backend_service_configs = {
+  default = {
+    backends = [{
+      group = "custom"
+    }]
+  }
+}
+group_configs = {
+  custom = {
+    zone = "europe-west1-b"
+    instances = [
+      "projects/myprj/zones/europe-west1-b/instances/vm-a"
+    ]
+    named_ports = { http = 80 }
+  }
+}

tests/modules/net_ilb_l7/groups.yaml

@@ -0,0 +1,21 @@
+# Copyright 2023 Google LLC
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+counts:
+  google_compute_forwarding_rule: 1
+  google_compute_health_check: 1
+  google_compute_instance_group: 1
+  google_compute_region_backend_service: 1
+  google_compute_region_target_http_proxy: 1
+  google_compute_region_url_map: 1