Skip to content

Commit

Permalink
small fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
simonebruzzechesse committed Sep 7, 2023
1 parent ce2dcf9 commit 4d1f66a
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
8 changes: 4 additions & 4 deletions blueprints/third-party-solutions/phpipam/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ documentation below.
give it a value that will be accepted in accordance to your policy.
2. By default, the application will be exposed externally through Global
Application Load Balancer, for restricting access to specific identities
please check iap configuration or deploy the application internally via the
please check IAP configuration or deploy the application internally via the
ILB
3. Setting the `phpipam_exposure` variable to "INTERNAL" will deploy an Internal
Application Load Balancer on the same VPC. This might be the preferred option
Expand All @@ -111,7 +111,7 @@ documentation below.

Initialize your Terraform environment and deploy the resources:

``` {shell}
```shell
terraform init
terraform apply
```
Expand All @@ -122,13 +122,13 @@ Upon completion, you will see the output with the values for the Cloud Run
service and the user and password to access the application.
You can also view it later with:

``` {shell}
```shell
terraform output
# or for the concrete variable:
terraform output cloud_run_service
```

Please be aware that password created in the script is not yet configured in the
Please be aware that the password created in the script is not yet configured in the
application, you will be prompted to insert that during phpIPAM installation
process at first login.
To access the newly deployed application follow these instructions:
Expand Down
2 changes: 2 additions & 0 deletions blueprints/third-party-solutions/phpipam/glb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ module "glb" {
name = "phpipam-glb"
address = module.addresses.0.global_addresses["phpipam"].address
protocol = "HTTPS"

backend_service_configs = {
default = {
backends = [
Expand Down Expand Up @@ -75,6 +76,7 @@ resource "google_compute_security_policy" "policy" {
count = local.glb_create && var.security_policy.enabled ? 1 : 0
project = module.project.project_id
name = "cloud-run-policy"

rule {
action = "deny(403)"
priority = 1000
Expand Down
1 change: 1 addition & 0 deletions blueprints/third-party-solutions/phpipam/ilb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ module "ilb-l7" {
name = "ilb-l7-cr"
protocol = "HTTPS"
region = var.region

backend_service_configs = {
default = {
project_id = var.project_id
Expand Down
2 changes: 2 additions & 0 deletions blueprints/third-party-solutions/phpipam/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ module "vpc" {
count = var.vpc_config == null ? 1 : 0
project_id = module.project.project_id
name = "${var.prefix}-sql-vpc"

psa_config = {
ranges = {
cloud-sql = var.ip_ranges.psa
Expand All @@ -97,6 +98,7 @@ module "cloud_run" {
prefix = var.prefix
ingress_settings = "all"
region = var.region

containers = {
phpipam = {
image = var.phpipam_config.image
Expand Down

0 comments on commit 4d1f66a

Please sign in to comment.