Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial README #1

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Initial README #1

merged 2 commits into from
Jun 11, 2019

Conversation

morgante
Copy link
Contributor

@morgante morgante commented May 3, 2019

No description provided.

@morgante morgante requested a review from aaron-lane May 3, 2019 21:59
@morgante
Copy link
Contributor Author

morgante commented May 3, 2019

@ludoo Could you take a look at this?

ludoo
ludoo reviewed May 4, 2019
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not make the production-grade distinction, Fabric is also meant to be used in production, the main point is it does not support all use cases, and you won't have someone managing it for you going forward.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@aaron-lane aaron-lane added the enhancement New feature or request label May 27, 2019
@aaron-lane
Copy link

@morgante do you have responses for @ludoo?

@morgante
Copy link
Contributor Author

@ludoo Please see updated README.

@aaron-lane aaron-lane requested a review from ludoo June 10, 2019 21:19
@ludoo
Copy link
Collaborator

ludoo commented Jun 11, 2019

Looks good, even though at this stage the repo is void of content, and the README will of course change dramatically once environments start getting in.

@ludoo ludoo merged commit 8d98626 into master Jun 11, 2019
@ludoo ludoo deleted the morgante-readme branch September 7, 2019 03:54
juliocc pushed a commit that referenced this pull request Feb 6, 2022
@danielmarzini
clusters improvement #1 and #2 (#509)
302e858 
* shared_vpc_self_link variable from stage2

* removing shared_vpc_self_link

* do not initial_node_count as node_count
juliodiez added a commit that referenced this pull request Jan 26, 2023
@juliodiez
Merge pull request #1 from GoogleCloudPlatform/master
05d57e1 
Sync fork
ludoo pushed a commit that referenced this pull request Jun 16, 2023
@kthhrv
Bump TF version in all workflow templates to coincide with module req…
a68a3b5 
…uirements (#1445)

* Resman - bump GH TF version to coincide with module requirements (#1)

Bootstrap was bumped in #1414

* Bump TF version in all workflow files

* bump TF version in missed workflow file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-lane aaron-lane Awaiting requested review from aaron-lane

@ludoo ludoo Awaiting requested review from ludoo

Assignees

@morgante morgante

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@morgante @aaron-lane @ludoo