Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing framework revamp #1029

Merged
merged 28 commits into from Dec 6, 2022
Merged

Testing framework revamp #1029

merged 28 commits into from Dec 6, 2022

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Nov 30, 2022

This includes new fixtures that compare a plan's resources, type counts and outputs against a set of yaml files.

The new fixtures (generic_plan_summary and generic_plan_validator) will:

  • remove the need of wrapper terraform modules
  • simplify the usage of tfvars files for tests
  • remove some magic and implicit behaviors present in the existing fixtures
  • allow testing module outputs

@ludoo ludoo self-requested a review November 30, 2022 19:43
@juliocc juliocc force-pushed the jccb/tests-revamp branch 3 times, most recently from c6769aa to 30c0f7e Compare December 5, 2022 09:29
@juliocc juliocc marked this pull request as ready for review December 5, 2022 09:56
@juliocc juliocc changed the title Testing framework revamp (wip) Testing framework revamp Dec 5, 2022
@juliocc juliocc disabled auto-merge December 5, 2022 11:11
ludoo
ludoo reviewed Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still have to digest most of it, couple of nits before I dive into this :)

tests/collectors.py Show resolved Hide resolved
tests/collectors.py Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
ludoo
ludoo reviewed Dec 6, 2022
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doing this piecemeal, will do validator next, this is super nice

tests/fixtures.py Outdated Show resolved Hide resolved
tests/fixtures.py Outdated Show resolved Hide resolved
tests/fixtures.py Outdated Show resolved Hide resolved
tests/fixtures.py Show resolved Hide resolved
@github-actions github-actions bot added the on:tools New or changed tool label Dec 6, 2022
@juliocc juliocc merged commit a17e245 into master Dec 6, 2022
@juliocc juliocc deleted the jccb/tests-revamp branch December 6, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliocc @ludoo