Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(blueprints): get audience from tfc environment variable #1034

Merged
merged 2 commits into from Dec 5, 2022

Conversation

Thomgrus
Copy link
Contributor

@Thomgrus Thomgrus commented Dec 3, 2022

Subject

This PR is about using Workload Identity Federation with Terraform Cloud.

Description

I propose this change because the audience in Terraform Cloud / Enterprise is already defined by the user in the TFC_WORKLOAD_IDENTITY_AUDIENCE environment variable for the workspace. So you can avoid to define it in the Terraform code as variable.

I take this opportunity to also correct a typo error in the documentation.

Thank you for the sample code, it helped me a lot to understand how to use Workload Identity Federation with Terraform Cloud.

Have a nice day ! 馃憢

@google-cla
Copy link

google-cla bot commented Dec 3, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Fix typo in documentation and get audience from Terraform Cloud `TFC_WORKLOAD_IDENTITY_AUDIENCE` environment variable.
@averbuks
Copy link
Member

averbuks commented Dec 5, 2022

Thank you @Thomgrus for the contribution, you are right, the var is already defined, that way provider configuration is even simpler.

@averbuks averbuks merged commit 3f91080 into GoogleCloudPlatform:master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants