Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting no ranges in firewall module custom rules #1073

Merged
merged 4 commits into from Dec 23, 2022
Merged

Allow setting no ranges in firewall module custom rules #1073

merged 4 commits into from Dec 23, 2022

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Dec 23, 2022

This changes the VPC firewall module so that custom rules mimick the resource behavior for source_ranges and destination_ranges:

  • if they are missing or set to null the module interpolates ["0.0.0.0/0"]
  • if they are set to an empty or populated list, no interpolation happens

It also switches module tests to the new format.

Fixes #1058

@ludoo ludoo enabled auto-merge (squash) December 23, 2022 01:32
@ludoo ludoo disabled auto-merge December 23, 2022 08:03
@ludoo ludoo merged commit 66a4020 into master Dec 23, 2022
@ludoo ludoo deleted the ludo/issue-1058 branch December 23, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc Awaiting requested review from juliocc

@sruffilli sruffilli Awaiting requested review from sruffilli

Assignees
No one assigned
Labels
on:blueprints on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net-vpc-firewall when using yaml rule format fails to generate correct rule with source_tags
1 participant
@ludoo