Use terraform resource to activate Anthos Service Mesh #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to update the tests |
Use google_gkehub_feature_membership to provision ASM on clusters. Ensure that the cluster membership is refreshed on cluster recreation.
wiktorn
force-pushed
the
google_gkehub_feature_membership
branch
from
341aaee
to
b38ef22
Compare
juliocc
reviewed
Jan 19, 2023
It's not needed to force recreation of membership when workload identity is configured.
|
LGTM. I defer to @apichick for final approval. |
juliocc
approved these changes
Jan 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.