Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First batch of testing updates to core modules #1101

Merged
merged 15 commits into from Jan 20, 2023
Merged

First batch of testing updates to core modules #1101

merged 15 commits into from Jan 20, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Jan 19, 2023

Updating the following modules to use the new example-based testing framework:

  • dns
  • gke-cluster
  • gke-nodepool
  • net-vpc

This PR also

  • adds the --example flag to the plan_summary.py tool to simulate execution as it happens within the examples contained in READMEs
  • Fixes long-standing bug in net-vpc dns policies not being applied correctly
  • Adds several new tests/examples to the modules mentioned above
  • Removes several python-based tests which are now handled as tested examples

@juliocc juliocc requested a review from ludoo January 19, 2023 17:26
@github-actions github-actions bot added on:modules on:tools New or changed tool labels Jan 19, 2023
ludoo
ludoo approved these changes Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@juliocc juliocc merged commit fef45ed into master Jan 20, 2023
@juliocc juliocc deleted the jccb/test-updates branch January 20, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:documentation on:modules on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliocc @ludoo