Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Network Dashboard: PSA support for Filestore and Memorystore #1106

Merged
merged 8 commits into from Jan 25, 2023
Merged

Network Dashboard: PSA support for Filestore and Memorystore #1106

merged 8 commits into from Jan 25, 2023

Conversation

aurelienlegrand
Copy link
Collaborator

Network Dashboard: IP utilization support for 2 more PSA based services: Filestore and Memorystore
Next step: GKE and secondary ranges.

ludoo
ludoo approved these changes Jan 21, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Dropped a trivial comment, and I'm not entirely sure about the change in formatting but I added the net dashboard folder to our Python formatting check, so we will catch any difference there.

blueprints/cloud-operations/network-dashboard/src/plugins/discover-cai.py Outdated Show resolved Hide resolved
@aurelienlegrand aurelienlegrand enabled auto-merge (squash) January 25, 2023 14:50
@aurelienlegrand aurelienlegrand merged commit 7f5c177 into master Jan 25, 2023
@aurelienlegrand aurelienlegrand deleted the net-dash-psa2 branch January 25, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:blueprints
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aurelienlegrand @ludoo