Add Autopilot Support for cluster_autoscaling Configuration in GKE Module #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
juliocc
reviewed
Feb 6, 2023
|
@danielmarzini can you review this? |
juliocc
reviewed
Feb 7, 2023
|
@tacchino can you rebase this pr too? |
juliocc
approved these changes
Feb 10, 2023
Support cluster_autoscaling configuration when using autopilot
auto-merge was automatically disabled
February 10, 2023 12:00
Head branch was pushed to by a user without write access
|
@juliocc done. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the cluster_autoscaling configuration block in the gke-cluster module when autopilot = true.
Previously this would fail because the enabled parameter could not be set with autoscaling enabled. Changed to set enabled = null and added support for the auto_provisioning_defaults configuration, primarily to allow for specification of a non-default service account