Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAST plugin system #1266

Merged
merged 26 commits into from Mar 24, 2023
Merged

FAST plugin system #1266

merged 26 commits into from Mar 24, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Mar 18, 2023

WIP

Fixes #1262

@ludoo
Copy link
Collaborator Author

ludoo commented Mar 18, 2023

@juliocc how do we test these, other than by hand when developing? :)

@ludoo ludoo requested a review from juliocc March 18, 2023 07:23
@juliocc
Copy link
Collaborator

juliocc commented Mar 21, 2023

Beautiful. I really like it.

@juliocc how do we test these, other than by hand when developing? :)

There's no reason we can't test them as a regular module. Just drop a few examples in the readme

For a more exhaustive test, we can try to enable them before running the corresponding FAST stage. I'll have to think about it a bit more.

@github-actions github-actions bot added the on:tools New or changed tool label Mar 24, 2023
@ludoo
Copy link
Collaborator Author

ludoo commented Mar 24, 2023

Beautiful. I really like it.

@juliocc how do we test these, other than by hand when developing? :)

There's no reason we can't test them as a regular module. Just drop a few examples in the readme

For a more exhaustive test, we can try to enable them before running the corresponding FAST stage. I'll have to think about it a bit more.

Plugins depend on the stage internals, we need to test them as part of their stage. Any ideas on how to do that in a simple way?

@ludoo ludoo marked this pull request as ready for review March 24, 2023 07:04
@ludoo ludoo enabled auto-merge (squash) March 24, 2023 11:07
@ludoo ludoo requested a review from juliocc March 24, 2023 12:21
@ludoo ludoo merged commit 3d41d01 into master Mar 24, 2023
8 checks passed
@ludoo ludoo deleted the ludo/fast-plugins branch March 24, 2023 12:28
lcaggio pushed a commit that referenced this pull request May 5, 2023
@ludoo @juliocc @lcaggio
FAST plugin system (#1266)
1057dcd 
* plugin folder, gitignore, serverless connector example

* add support to fast plugin variables and outputs to tfdoc

* rename folder, READMEs

* add variable description

* show diffs

* check documentation, use multiple files

* debug check doc

* try a different glob

* debug tfdoc names

* more debug

* and even more debug

* fix gitignore

* fix links

* support extra files in tests

* fix fixture, switch stage 2 peering to new tests

* tfdoc

* Allow globs in extra files

---------

Co-authored-by: Julio Castillo <jccb@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:FAST on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FAST plugin system
2 participants
@ludoo @juliocc