Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to NCC-RA spoke module. #1267

Merged
merged 2 commits into from Mar 21, 2023
Merged

Improvements to NCC-RA spoke module. #1267

merged 2 commits into from Mar 21, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Mar 20, 2023 •
edited

  • Users can now set route priorities
  • Prefixes all GCP names with a prefix so the module can be instantiated multiple times in the same project
  • Calls the variables and add suffixes 0 and 1 (instead of 1 and 2) to interfaces and peers to reflect the GCP nomenclature

@LucaPrete LucaPrete requested a review from ludoo March 20, 2023 14:05
@LucaPrete LucaPrete enabled auto-merge (squash) March 21, 2023 06:43
@LucaPrete LucaPrete merged commit 3b20d61 into master Mar 21, 2023
8 checks passed
@LucaPrete LucaPrete deleted the ncc-ra-improvements branch March 21, 2023 07:07
lcaggio pushed a commit that referenced this pull request May 5, 2023
@LucaPrete @lcaggio
Improvements to NCC-RA spoke module. (#1267)
98af0bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucaPrete @ludoo