Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple-nva: add ability to parse BGP configs as strings. #1268

Merged
merged 3 commits into from Mar 21, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Mar 20, 2023

Users can now pass FRR BGP configs as strings and not just as paths to existing files. This is useful if templatefile is used in the caller module.

Copy link
Collaborator

@simonebruzzechesse simonebruzzechesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement that will simplify usage of this module

@LucaPrete LucaPrete merged commit 6e49e94 into master Mar 21, 2023
8 checks passed
@LucaPrete LucaPrete deleted the simple-nva-improvements branch March 21, 2023 06:41
lcaggio pushed a commit that referenced this pull request May 5, 2023
* Add ability to parse BGP configs as strings.

* Fix var name

* Refresh tfdoc

---------

Co-authored-by: Luca Prete <lucaprete@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants