Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Response Policy module #1276

Merged
merged 3 commits into from Mar 26, 2023
Merged

DNS Response Policy module #1276

merged 3 commits into from Mar 26, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Mar 26, 2023

FAST modules will be updated to use response policies in a subsequent PR.

@ludoo ludoo enabled auto-merge (squash) March 26, 2023 08:45
Copy link
Member

@LucaPrete LucaPrete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor comments, otherwise lgtm

modules/dns-response-policy/outputs.tf Show resolved Hide resolved
modules/dns-response-policy/variables.tf Show resolved Hide resolved
modules/dns-response-policy/variables.tf Show resolved Hide resolved
modules/dns-response-policy/versions.tf Show resolved Hide resolved
modules/dns-response-policy/versions.tf Show resolved Hide resolved
README.md Show resolved Hide resolved
modules/dns-response-policy/README.md Show resolved Hide resolved
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope you don't mind that I added inventories to your two examples

@ludoo ludoo merged commit 28da881 into master Mar 26, 2023
8 checks passed
@ludoo ludoo deleted the ludo/dns-rpz branch March 26, 2023 15:42
@ludoo
Copy link
Collaborator Author

ludoo commented Mar 26, 2023

ouch, automerge kicked in before I could send the fix to copyright etc

lcaggio pushed a commit that referenced this pull request May 5, 2023
* dns response policy module

* tfdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants