Use unique bundle name for Cloud Function #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When cloud-function module is used multiple times within project and default `bundle_config.output_path` is used then all the instances try to use filename and result is undefined without guarantee to converge to desired state (i.e. multiple functions may share the same code).
wiktorn
force-pushed
the
cloud_functions_non_conflicting_bundle
branch
from
eb2e2cb
to
9d04724
Compare
juliocc
approved these changes
Mar 27, 2023
Can you add a test ensuring two calls to the module generate a different bundle path? |
wiktorn
force-pushed
the
cloud_functions_non_conflicting_bundle
branch
3 times, most recently
from
0f5d618
to
87118aa
Compare
wiktorn
force-pushed
the
cloud_functions_non_conflicting_bundle
branch
from
87118aa
to
16167c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When cloud-function module is used multiple times within project and default
bundle_config.output_pathis used then all the instances try to use filename and result is undefined without guarantee to converge to desired state (i.e. multiple functions may share the same code).