Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing enable_addons reference in gke blueprint for multitenant-… #1305

Merged

Conversation

jackspyder
Copy link
Contributor

Small fix for the GKE blueprint multitenant-fleet adding the missing enable_addons call to the underlying gke-cluster module call.

@google-cla
Copy link

google-cla bot commented Apr 4, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Apr 4, 2023

hi @jackspyder, thanks for catching this. Can you sign the CLA so we can merge this?

@jackspyder
Copy link
Contributor Author

@juliocc I'm chasing this up and will respond ASAP

@jackspyder
Copy link
Contributor Author

jackspyder commented Apr 6, 2023

Hey @juliocc I've signed a corporate CLA, i'm the group owner, its publicly visible, my commit is with my corporate email which is also added to my github account (though not my primary mail). It was signed last night so maybe takes some time to show up? Sorry if im wasting your time on such a small change.

Edit: Seems someone on the google side may need to approve. Sorry for the delay.

@juliocc
Copy link
Collaborator

juliocc commented Apr 7, 2023

Hey @jackspyder, unfortunately the CLA is still showing as failed. Can you double check once again?

@jackspyder
Copy link
Contributor Author

@juliocc finally the CLA is signed! So sorry about the delay for such a small change!

@juliocc
Copy link
Collaborator

juliocc commented Apr 11, 2023

Awesome, thanks @jackspyder. Now you have to rebase you branch wi master so we can merge it.

@juliocc juliocc enabled auto-merge April 11, 2023 09:28
auto-merge was automatically disabled April 11, 2023 09:32

Head branch was pushed to by a user without write access

@juliocc juliocc enabled auto-merge April 11, 2023 12:53
@juliocc juliocc merged commit e20c092 into GoogleCloudPlatform:master Apr 11, 2023
8 checks passed
@jackspyder jackspyder deleted the jackspyder/gke-blueprint-fix branch May 8, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants