Extend tests to use lockfile if available #1340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
reviewed
Apr 23, 2023
|
Yeah, I'm still trying to figure out the details and I'll clean it up once
it's working.
…On Sun, Apr 23, 2023, 7:38 AM Ludovico Magnocavallo < ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .github/workflows/tests.yml
<#1340 (comment)>
:
>
jobs:
+ setup-tf-providers:
+ runs-on: ubuntu-latest
can't you put this in the composite action? there's also a duplicate step
—
Reply to this email directly, view it on GitHub
<#1340 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAYRPPJZJDCHYM62BRMP3TXCS54NANCNFSM6AAAAAAXIDN33Q>
.
You are receiving this because you authored the thread.Message ID:
<GoogleCloudPlatform/cloud-foundation-fabric/pull/1340/review/1396840354@
github.com>
|
This commints allows the test framework to use a lockfile generated within the tools/lockfile directory. This allows reusing the provider cache and also running tests in parallel.
juliocc
force-pushed
the
jccb/tests-lockfile
branch
from
97e184e
to
ee4a908
Compare
juliocc
force-pushed
the
jccb/tests-lockfile
branch
from
1234242
to
f4b8a61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commints allows the test framework to use a lockfile generated within the tools/lockfile directory. This allows reusing the provider cache and also running tests in parallel.