Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance GKE Backup Configuration Support #1349

Merged
merged 3 commits into from May 2, 2023
Merged

Enhance GKE Backup Configuration Support #1349

merged 3 commits into from May 2, 2023

Conversation

tacchino
Copy link
Contributor

@tacchino tacchino commented May 2, 2023

Adds support for more detailed GKE backup config

  • non default include_volume_data
  • non default include_secrets
  • encryption_key
  • selected_namespaces

ludoo
ludoo approved these changes May 2, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to rerun tfdoc, linting check probably fails there :)

thanks for this, dropped a couple minor comments

@ludoo ludoo enabled auto-merge (squash) May 2, 2023 14:37
@ludoo ludoo disabled auto-merge May 2, 2023 14:37
@ludoo ludoo enabled auto-merge (squash) May 2, 2023 14:56
@ludoo ludoo merged commit 5763eb5 into GoogleCloudPlatform:master May 2, 2023
9 checks passed
@tacchino
Copy link
Contributor Author

tacchino commented May 2, 2023

Awesome, thanks for the the fast review @ludoo

@ludoo
Copy link
Collaborator

ludoo commented May 2, 2023

Thank you! :)

@tacchino tacchino deleted the autopilot_backups branch May 2, 2023 16:57
lcaggio pushed a commit that referenced this pull request May 5, 2023
@tacchino @lcaggio
Enhance GKE Backup Configuration Support (#1349)
7f3e417 
* Add more support for backup configuration

* Update docs

* Remove redundant lookups
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tacchino @ludoo