Switch FAST networking stages to network policies for Google domains #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drebes
reviewed
May 3, 2023
drebes
reviewed
May 3, 2023
juliocc
reviewed
May 3, 2023
There was a problem hiding this comment.
beautiful
Can we include the other domains mentioned [here](https://cloud.google.com/vpc/docs/configure-private-google-access#domain-options
ludoo
added
the
incompatible change
…d-foundation-fabric into ludo/issue-1292
juliocc
approved these changes
May 4, 2023
lcaggio
pushed a commit
that referenced
this pull request
May 5, 2023
…1352) * peering stage implementation * vpn stage implementation * tfdoc * tests * add most supported google domains * align all net stages * add support for factory to DNS response policy module * use dns policy factory in network stages * boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1292 by removing all private zones supporting Google domains for APIs, and reimplementing them via a single response policy for added flexibility.
Updated to implement a factory in the DNS resource policy module, and to use corresponding factory files in FAST networking stages.