Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module link to README #1357

Merged
merged 20 commits into from May 5, 2023
Merged

Add module link to README #1357

merged 20 commits into from May 5, 2023

Conversation

prabhaarya
Copy link
Collaborator

@prabhaarya prabhaarya commented May 5, 2023

Cloud-Dataplex module added to the repo.

  • Add module link to root level README
  • Add module link to module folders README.

Fixes #1356

@lcaggio
Copy link
Collaborator

lcaggio commented May 5, 2023

There are all commits from the previous PR, can you fix it? A rebase should fix it (or feel free to close this and create a new PR).

@ludoo
Copy link
Collaborator

ludoo commented May 5, 2023

You can also close this, and do it in a branch in this repo, even just using the Github inline editor. :)

@ludoo
Copy link
Collaborator

ludoo commented May 5, 2023

THis looks good now.

@ludoo ludoo enabled auto-merge (squash) May 5, 2023 08:06
@ludoo ludoo merged commit c344606 into GoogleCloudPlatform:master May 5, 2023
9 checks passed
lcaggio added a commit that referenced this pull request May 5, 2023
* Add dataplex module

* fix dataplex test

* resolve comments

* python test removed

* Change variable desc

* refactor variables

* fix typos

* fix assets & zones resources

* fix linting error

* fix tests

* fix typo

* add module link in README

---------

Co-authored-by: lcaggio <lorenzo.caggioni@gmail.com>
Co-authored-by: Ludovico Magnocavallo <ludomagno@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link new dataplex module from READMEs
3 participants