Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice to net-ilb module on routes #1415

Merged
merged 8 commits into from Jun 5, 2023
Merged

Add notice to net-ilb module on routes #1415

merged 8 commits into from Jun 5, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Jun 3, 2023 •
edited

This adds a notice to the README file on how to prevent a circular dependency, when using the module to create ILBaNH routes in the VPC module..

@ludoo ludoo requested a review from juliocc June 3, 2023 15:28
@ludoo ludoo enabled auto-merge (squash) June 3, 2023 15:28
@ludoo ludoo changed the title Add support for routes to net-ilb module Add notice to net-ilb module on routes Jun 4, 2023
@ludoo ludoo disabled auto-merge June 4, 2023 10:02
juliocc
juliocc approved these changes Jun 5, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes :)

@ludoo ludoo merged commit c439a66 into master Jun 5, 2023
9 checks passed
@ludoo ludoo deleted the ludo/ilb-route branch June 5, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ludoo @juliocc