Updating hub-and-spoke peering blueprint to use HA VPN. #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We have an example of a hub and spoke via HA VPN in FAST. THanks for this PR, but I don't think we should change this blueprint to switch from peering to VPN. Maybe pointing to the FAST example from the README is enough, all FAST stages are usable in isolation. |
|
Hi Ludovico,
Understood. However, unless I goofed, this PR doesn't change the
hub-and-spoke configuration itself. All it does is change the transitive
routing bit from static VPN to HA VPN setup. I did this because we're
trying to get away from static VPN, if I understand the product goals
correctly.
I definitely don't want to change the core goal of the blueprint.
Additional thoughts on that?
Thanks.
Mark
…On Thu, Jun 8, 2023 at 11:56 AM Ludovico Magnocavallo < ***@***.***> wrote:
We have an example of a hub and spoke via HA VPN in FAST. THanks for this
PR, but I don't think we should change this blueprint to switch from
peering to VPN. Maybe pointing to the FAST example from the README is
enough, all FAST stages are usable in isolation.
—
Reply to this email directly, view it on GitHub
<#1427 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASB6AMKIA55IOZKH77A3CDXKIN6JANCNFSM6AAAAAAY6QGVM4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
Ooops sorry, I had a quick look and got a completely wrong idea :( It should teach me never to do things in a hurry. Do you need help with the failing checks? |
|
Thanks Ludovico!
Julio has offered to help on the failing checks. I understand one of them
now. I think I can get through the others, but I'll definitely ask for help
if I get stuck. Thanks!
Mark
…On Thu, Jun 8, 2023 at 10:43 PM Ludovico Magnocavallo < ***@***.***> wrote:
Ooops sorry, I had a quick look and got a completely wrong idea :( It
should teach me never to do things in a hurry.
Do you need help with the failing checks?
—
Reply to this email directly, view it on GitHub
<#1427 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AASB6AMO37PMB3FRZN6L5MTXKKZY5ANCNFSM6AAAAAAY6QGVM4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
juliocc
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating terraform to use HA VPN. Updating README to reflect the change and to incorporate some of the text from the reference architecture.