feat(artifact-registry): Add support for CMEK #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
approved these changes
Jun 20, 2023
* split v1 * v2 * blueprints * remove _http
#1446) * fixup(project-factory): Use the correct KMS Service Agents attribute name * Add new KMS bindings to tests * Update test resource counts * Update README.md resource count
auto-merge was automatically disabled
June 20, 2023 07:27
Head branch was pushed to by a user without write access
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
To extend the Google Artifact Registry module to support enabling encryption at rest with a user-supplied KMS key.
Problem
Most of the FAST framework encourages and supports the use of CMEK keys. While using the framework, we've found that we couldn't use this module to provision Google Artifact Registry repositories because the default organizational policies enforce repositories to be encrypted at rest and, the current version of the module, does not support passing in a KMS key to enable encryption at rest.
Solution
To extend the module API to optionally accept a KMS key name to be used to encrypt the artifact blobs' at rest.