Changing the IP range of pods from 100.64.48.0/20 to 100.65.16.0/20 Fixes #1461 #1477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as there is an overlap in 100.64.0.0/16 range with dev-gke-nodes-ew1.yaml
juliocc
approved these changes
Jun 28, 2023
fast/stages/2-networking-a-peering/data/subnets/dev/dev-dataplatform-ew1.yaml
Outdated
Show resolved
Hide resolved
juliocc
requested changes
Jun 28, 2023
|
Changed the IP ranges in all networking stages |
arvindag07
changed the title
|
Ack, made the changes !
…On Wed, Jun 28, 2023 at 2:52 PM Roberto Jung Drebes < ***@***.***> wrote:
Can you edit the original description and add "Fixes #1461
<#1461>"?
Thank you.
—
Reply to this email directly, view it on GitHub
<#1477 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3SQB5GCVPPYZXTVU7T7WTLXNR4OLANCNFSM6AAAAAAZXPTCHI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
Sorry, I didn't explain myself clearly. Let's make sure DP and GKE use the same ranges in all networking stages. For DP we want (@lcaggio can you LGTM these ranges?):
For GKE we want (@danielmarzini can you LGTM these ranges?):
This means updating the following subnets with the ranges above:
Stages c, d, and e don't have the GKE subnet. We'll track that in #1481 @simonebruzzechesse @sruffilli can you quickly make sure these ranges are ok in your net stages? |
arvindag07
force-pushed
the
ip-conflict-remove
branch
from
d48a638
to
d3e4864
Compare
|
Thanks for the detailed comment. Made all the suggested changes as mentioned in #1477 (comment). Please review |
juliocc
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> Changing the IP range of pods from 100.64.48.0/20 to 100.65.16.0/20 in
fast/stages/2-networking-a-peering/data/subnets/dev/dev-dataplatform-ew1.yamlas there is an overlap in 100.64.0.0/16 range withfast/stages/2-networking-a-peering/data/subnets/dev/dev-gke-nodes-ew1.yaml1"Fixes #1461"