Update ncc-spoke-ra module to explicity request ncc hub id when referencing existing hubs #1479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludoo
changed the title
LucaPrete
reviewed
Jun 29, 2023
|
Thanks @simonebruzzechesse . LGTM in general, besides minor comments |
simonebruzzechesse
force-pushed
the
bruzz/fix-ncc-spoke-ra-module
branch
from
34d47e9
to
fda86c4
Compare
sruffilli
approved these changes
Jul 3, 2023
LucaPrete
approved these changes
Jul 6, 2023
simonebruzzechesse
force-pushed
the
bruzz/fix-ncc-spoke-ra-module
branch
3 times, most recently
from
18cd92f
to
f180b91
Compare
simonebruzzechesse
force-pushed
the
bruzz/fix-ncc-spoke-ra-module
branch
from
f180b91
to
15bd2f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified module input variable to deal with ncc hub creation (passing the name of the hub to create) as well as referencing existing hub via id (instead of the name). Only specifying the name of the hub (even if in the same project) led to strange terraform behaviour (name of the hub being interpreted as the project id somehow), at least in the latest version of the provider.