Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused ASN numbers from CloudNAT to avoid provider errors #1566

Merged
merged 1 commit into from Aug 4, 2023
Merged

Remove unused ASN numbers from CloudNAT to avoid provider errors #1566

merged 1 commit into from Aug 4, 2023

Conversation

LucaPrete
Copy link
Member

No description provided.

@LucaPrete LucaPrete enabled auto-merge (squash) August 4, 2023 07:53
ludoo
ludoo approved these changes Aug 4, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Luca, can you explain the rationale and show an error in this PR's description, for future reference?

@LucaPrete LucaPrete merged commit 311bed8 into master Aug 4, 2023
9 checks passed
@LucaPrete LucaPrete deleted the remove_asn_cnat branch August 4, 2023 08:02
@ludoo
Copy link
Collaborator

ludoo commented Aug 4, 2023

@LucaPrete thanks for ignoring my comment

@LucaPrete
Copy link
Member Author

@ludoo lool sorry the auto-merge kicked in!

The rationale is that this returns an error

Error: Attribute must be a whole number, got 4.200001024e+09
│ 
│   with module.prod-spoke-cloudnat["europe-west1"].google_compute_router.router[0],
│   on ../../../modules/net-cloudnat/main.tf line 32, in resource "google_compute_router" "router":
│   32:     asn = var.router_asn
│ 
╵
╷
│ Error: Attribute must be a whole number, got 4.200001024e+09
│ 
│   with module.dev-spoke-cloudnat["europe-west1"].google_compute_router.router[0],
│   on ../../../modules/net-cloudnat/main.tf line 32, in resource "google_compute_router" "router":
│   32:     asn = var.router_asn
│

On the other hand, NAT doesn't need any ASN setting.

Hope it helps clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@juliocc juliocc juliocc approved these changes

@drebes drebes Awaiting requested review from drebes

@sruffilli sruffilli Awaiting requested review from sruffilli

Assignees
No one assigned
Labels
on:FAST
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LucaPrete @ludoo @juliocc