Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ipv6 to net-vpc module #1568

Merged
merged 3 commits into from Aug 5, 2023
Merged

Add support for ipv6 to net-vpc module #1568

merged 3 commits into from Aug 5, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Aug 5, 2023

Fixes #1530

Copy link

@Avinash-jayakumar Avinash-jayakumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. the "private_ipv6_google_access" does not take true or false value. If we give true or false, terraform plan shows a change in resource everytime we run the code. Setting it to null or not having that attribute should work fine. I Could see you have commented it.

@ludoo
Copy link
Collaborator Author

ludoo commented Aug 5, 2023

Change looks good. the "private_ipv6_google_access" does not take true or false value. If we give true or false, terraform plan shows a change in resource everytime we run the code. Setting it to null or not having that attribute should work fine. I Could see you have commented it.

Yep. If you look at the code it's a string, but there's no value that can be set according to the API so I commented it out.

image

(edited, first reply was from mobile)

@ludoo ludoo enabled auto-merge (squash) August 5, 2023 10:38
@ludoo ludoo merged commit aecba0b into master Aug 5, 2023
9 checks passed
@ludoo ludoo deleted the ludo/issue-1530 branch August 5, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Net-vpc module doesnot support IPV6
3 participants