Expose allow_net_admin feature in gke-cluster-autopilot module #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
juliocc
requested changes
Aug 7, 2023
There was a problem hiding this comment.
Besides the inline comments, please make sure to:
- Update the README.md using the tfdoc script. Review the contributing guide for more details.
- Bump the provider version in default-versions.tf and copy it to versions.tf in every module.
- Sign the CLA
|
@eunanhardy I can take care of the failing tests |
|
Thanks @juliocc was just about to ask about that. |
juliocc
approved these changes
Aug 7, 2023
|
Tests should be fixed now. Once they pass we can go ahead and merge this. Thanks @eunanhardy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raised in this issue #1571
Summary of changes