Cloud SQL activation policy selectable #1613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added activation policy
added activation_policy variable defaulted as ALWAYS for non regression
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
juliocc
requested changes
Aug 23, 2023
|
@juliocc please could you review/Approve in order to check subsequent wf status? thx |
juliocc
requested changes
Aug 25, 2023
There was a problem hiding this comment.
I tried the module and I'm getting the following error:
Error running command plan: 1
Error: Unsupported argument
on fabric/modules/cloudsql-instance/main.tf line 122, in resource "google_sql_database_instance" "primary":
122: activation_policy = var.activation_policy
An argument named "activation_policy" is not expected here.
Please make sure to test the proposed changes.
juliocc
approved these changes
Aug 25, 2023
|
Thank you @juliocc for your valuable work and the patience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR make the Cloud SQL activation policy changeable from the default ALWAYS value. it yet does validation on input and is defaulted in order to don't make regressions on previous module. This PR make possible to manage databases that are not alway started (Eg. non production envs, historical data storage etc)