Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make net-vpc variables non-nullable #1650

Merged
merged 1 commit into from Sep 6, 2023
Merged

Make net-vpc variables non-nullable #1650

merged 1 commit into from Sep 6, 2023

Conversation

juliocc
Copy link
Collaborator

@juliocc juliocc commented Sep 6, 2023

The net-vpc module breaks if some of the variables are set to null. This PR makes those variables non-nullable

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@juliocc juliocc changed the title Make net-vpc variables nullable Make net-vpc variables non-nullable Sep 6, 2023
@juliocc juliocc merged commit c301fd6 into master Sep 6, 2023
13 checks passed
@juliocc juliocc deleted the jccb/net-vpc-nullables branch September 6, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruffilli sruffilli sruffilli approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@juliocc @sruffilli