Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1661] Make FAST stage 1 resman tf destroy more reliable #1663

Merged
merged 1 commit into from Sep 8, 2023

Conversation

LucaPrete
Copy link
Member

It sometimes happens that when the FAST stage 1 TF destroy process breaks half way through, we get some errors on outputs:

Error: Unsupported attribute
│
│   on outputs.tf line 226, in locals:
│  226:     tag_keys         = { for k, v in module.organization.tag_keys : k => v.id }
│     ├────────────────
│     │ module.organization is object with 8 attributes
│
│ This object does not have an attribute named "tag_keys".
╵
╷
│ Error: Unsupported attribute
│
│   on outputs.tf line 228, in locals:
│  228:     tag_values       = { for k, v in module.organization.tag_values : k => v.id }
│     ├────────────────
│     │ module.organization is object with 8 attributes
│
│ This object does not have an attribute named "tag_values".

While the real cause is still unknown, this patch tries to address the problem tactically, adding some try statements where needed.

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@LucaPrete LucaPrete enabled auto-merge (squash) September 8, 2023 09:47
@LucaPrete LucaPrete merged commit fcefadb into master Sep 8, 2023
13 checks passed
@LucaPrete LucaPrete deleted the resman_destroy branch September 8, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants