Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compute-mig): add mode property to compute_region_autoscaler #1667

Merged
merged 2 commits into from Sep 11, 2023

Conversation

NotArpit
Copy link
Contributor

@NotArpit NotArpit commented Sep 11, 2023

Description

The compute-mig module at //modules/compute-mig takes in the mode property via the variable autoscaler_config but does not propagate it to the google_compute_autoscaler and google_compute_region_autoscaler resources in autoscaler.tf.


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@google-cla
Copy link

google-cla bot commented Sep 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Sep 11, 2023

Nice catch.

Can you sign the CLA so we can merge this?

@NotArpit
Copy link
Contributor Author

NotArpit commented Sep 11, 2023

Can you sign the CLA so we can merge this?

Done.

@ludoo ludoo merged commit f225b60 into GoogleCloudPlatform:master Sep 11, 2023
9 checks passed
@NotArpit NotArpit deleted the arpit-mig-fix branch September 11, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants