Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added possibility to use gcs push endpoint on pubsub subscription #1672

Conversation

luigi-bitonti
Copy link
Contributor


Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@google-cla
Copy link

google-cla bot commented Sep 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Sep 13, 2023

thanks @luigi-bitonti! this lgtm.

@luigi-bitonti
Copy link
Contributor Author

luigi-bitonti commented Sep 13, 2023

It's a pleasure @juliocc ! Do I have to fmt also the documentation? I see that it didn't pass a check about formattation.

@juliocc
Copy link
Collaborator

juliocc commented Sep 13, 2023

Yes, just run your code through terraform fmt

@juliocc juliocc merged commit e19f332 into GoogleCloudPlatform:master Sep 13, 2023
9 checks passed
@luigi-bitonti luigi-bitonti deleted the luigi-bitonti/pubsub-gcs-feature branch September 14, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants