Embed subnet-level IAM in the variables controlling creation of subnets #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliocc
force-pushed
the
jccb/subnet-iam
branch
from
e782290
to
d20da2a
Compare
This moves the top-level `iam`, `iam_bindings` and `iam_bindings_additive` variables into subnet-level attributes. This change also allows setting permissions to PSC or proxy-only subnets As part of this change, the factory interface is more aligned with the rest of the modules using a `factories_config` variable. In the future we can add a cidrs template similar to the firewall policy module
juliocc
force-pushed
the
jccb/subnet-iam
branch
from
ff20bf3
to
f3be29c
Compare
ludoo
added
the
incompatible change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the top-level
iam,iam_bindingsandiam_bindings_additivevariables into subnet-level attributes. This change also allows setting permissions to PSC or proxy-only subnetsAs part of this change, the factory interface is more aligned with the rest of the modules using a
factories_configvariable. In the future we can add a cidrs template similar to the firewall policy moduleChecklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py