Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GKE cluster modules: add optional kube state metrics #1682

Conversation

olliefr
Copy link
Collaborator

@olliefr olliefr commented Sep 15, 2023

Provider version v4.82.0 introduced support for optional kube state metrics in GKE.

This pull request adds support for these metrics to gke-cluster-standard and gke-cluster-autopilot modules.

This was requested by @juliocc in #1665 (comment)

I also updated the blueprints that depend on gke-cluster-* modules as well as the relevant FAST stage.

There are some updates to the docs and new tests as well.

Checklist

I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments, just great.

@juliocc
Copy link
Collaborator

juliocc commented Sep 15, 2023

Oh you'll have to bump the provider version. Update the default-version.tf in the root and then find -name versions.tf -exec cp default-versions.tf {} \;

@olliefr
Copy link
Collaborator Author

olliefr commented Sep 15, 2023

@juliocc thanks for the tip! Provider version bumped up as you have suggested. Hopefully it'll work this time... :shipit:

@olliefr olliefr marked this pull request as ready for review September 15, 2023 11:17
@olliefr olliefr merged commit 6eb862a into GoogleCloudPlatform:master Sep 15, 2023
9 checks passed
@olliefr olliefr deleted the olliefr/gke-cluster-add-kube-state-metrics branch September 15, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants