Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GCS IAM #1727

Merged
merged 5 commits into from Oct 4, 2023
Merged

Update GCS IAM #1727

merged 5 commits into from Oct 4, 2023

Conversation

apichick
Copy link
Collaborator

@apichick apichick commented Oct 3, 2023 •
edited

Changes in IAM for GCS module

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

juliocc
juliocc approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

modules/gcs/main.tf Outdated Show resolved Hide resolved
@juliocc juliocc changed the title Gcs iam Update GCS IAM Oct 3, 2023
ludoo
ludoo reviewed Oct 4, 2023
View reviewed changes
modules/gcs/main.tf Outdated Show resolved Hide resolved
@apichick apichick merged commit d9ab23a into GoogleCloudPlatform:master Oct 4, 2023
9 checks passed
@apichick apichick deleted the gcs-iam branch October 4, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo left review comments

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@apichick @ludoo @juliocc