Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AI models support #1750

Merged
merged 19 commits into from Oct 25, 2023
Merged

AI models support #1750

merged 19 commits into from Oct 25, 2023

Conversation

ewojtach
Copy link
Member

Adds support for configuration of GCS Fuse CSI driver and GPU driver in GKE cluster standard and GKE nodepool modules.

Checklist

I applicable, I acknowledge that I have:

  • [ x] Read the contributing guide
  • [ x] Ran terraform fmt on all modified files
  • [ x] Regenerated the relevant README.md files using tools/tfdoc.py
  • [ x] Made sure all relevant tests pass

juliocc
juliocc reviewed Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks @ewojtach!

I left a couple of comments below. Also, can you add an example showing how to use the variables you're adding?

modules/gke-nodepool/variables.tf Outdated Show resolved Hide resolved
modules/gke-nodepool/main.tf Outdated Show resolved Hide resolved
modules/gke-nodepool/main.tf Outdated Show resolved Hide resolved
modules/gke-nodepool/variables.tf Show resolved Hide resolved
juliocc
juliocc requested changes Oct 16, 2023
View reviewed changes
modules/gke-nodepool/main.tf Outdated Show resolved Hide resolved
modules/gke-nodepool/main.tf Show resolved Hide resolved
modules/gke-nodepool/README.md Outdated Show resolved Hide resolved
modules/gke-nodepool/variables.tf Show resolved Hide resolved
@ewojtach ewojtach changed the title AI models support WIP: AI models support Oct 25, 2023
juliocc
juliocc approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@juliocc juliocc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ewojtach I did a couple of changes behind the scenes (merged master, extended the inventory).

This is good to merge now. Thanks for your patience.

@juliocc juliocc enabled auto-merge (squash) October 25, 2023 07:10
@juliocc juliocc disabled auto-merge October 25, 2023 07:20
@ewojtach ewojtach changed the title WIP: AI models support AI models support Oct 25, 2023
@juliocc juliocc enabled auto-merge (squash) October 25, 2023 09:22
@juliocc juliocc merged commit 33ce0e1 into GoogleCloudPlatform:master Oct 25, 2023
9 checks passed
@dominicrjames dominicrjames mentioned this pull request Feb 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewojtach @juliocc @ludoo