Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource manager tag bindings in compute-vm module #1771

Merged
merged 6 commits into from Oct 18, 2023
Merged

Fix resource manager tag bindings in compute-vm module #1771

merged 6 commits into from Oct 18, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Oct 17, 2023

Fixes #1763.

Context of the change is in the linked issue.

@ludoo ludoo requested review from juliocc and wiktorn October 17, 2023 21:51
@ludoo ludoo enabled auto-merge (squash) October 17, 2023 21:51
wiktorn
wiktorn approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

modules/compute-vm/README.md Outdated Show resolved Hide resolved
@ludoo ludoo merged commit 02ccc57 into master Oct 18, 2023
13 checks passed
@ludoo ludoo deleted the ludo/issue-1763 branch October 18, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

@juliocc juliocc Awaiting requested review from juliocc

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compute VM, tag_bindings don't work
2 participants
@ludoo @wiktorn