Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Apigee add-ons configuration #1798

Merged
merged 5 commits into from Oct 25, 2023

Conversation

mwarm2
Copy link
Contributor

@mwarm2 mwarm2 commented Oct 23, 2023

When using the apigee module, Terraform keeps planning an update for the add-ons configuration (google_apigee_addons_config.addons_config), because the provider does not expect the add-on's block when it's disabled (add-on can either have a block with enabled = true or its block not present at all).

See discussion here


Checklist

I applicable, I acknowledge that I have:

  • [ x ] Read the contributing guide
  • [ x ] Ran terraform fmt on all modified files
  • [ x ] Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

…n/fix-apigee-addons-config"

This reverts commit ec7a7a9, reversing
changes made to df5daab.
When a given add-on's variable is set to true, do instantiate the block.
@google-cla
Copy link

google-cla bot commented Oct 23, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@juliocc
Copy link
Collaborator

juliocc commented Oct 23, 2023

@mwarm2 can you sign the cl so we can go ahead and merge this?

@juliocc
Copy link
Collaborator

juliocc commented Oct 23, 2023

ignore my previous message, it's already signed. It'll merge once all tests pass

@ludoo ludoo enabled auto-merge (squash) October 25, 2023 07:16
@ludoo ludoo merged commit e28f7c3 into GoogleCloudPlatform:master Oct 25, 2023
9 checks passed
@mwarm2 mwarm2 deleted the mwarm2/fix_apigee_addons branch October 25, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants