Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMS module: Import job feature #1817

Merged
merged 10 commits into from Oct 30, 2023
Merged

KMS module: Import job feature #1817

merged 10 commits into from Oct 30, 2023

Conversation

cmalpe
Copy link
Collaborator

@cmalpe cmalpe commented Oct 27, 2023

Added support import job support for the "kms" module using the official terraform resource "google_kms_key_ring_import_job". Link: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/kms_key_ring_import_job.

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@cmalpe cmalpe requested review from ludoo and juliocc October 27, 2023 07:25
ludoo
ludoo approved these changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@ludoo ludoo removed the request for review from juliocc October 27, 2023 23:29
@cmalpe cmalpe merged commit 5ada65a into master Oct 30, 2023
13 checks passed
@cmalpe cmalpe deleted the cmalpe/kms-import-job branch October 30, 2023 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmalpe @ludoo