Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serverless networking program #1819

Merged
merged 56 commits into from Jan 5, 2024
Merged

Serverless networking program #1819

merged 56 commits into from Jan 5, 2024

Conversation

juliodiez
Copy link
Collaborator

Blueprint to deploy two microservices running in Cloud Run and communicating with each other.

The content of this blueprint corresponds to the chapter 'Microservices architectures - Developing Microservices applications' of the Serverless Networking Guide (https://services.google.com/fh/files/misc/serverless_networking_guide.pdf).


Checklist
I applicable, I acknowledge that I have:

  • [ x] Read the contributing guide
  • [ x] Ran terraform fmt on all modified files
  • [ x] Regenerated the relevant README.md files using tools/tfdoc.py
  • [ x] Made sure all relevant tests pass

Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a lot of comments in #1768 also apply here, especially incorporating external code + docker image build.

@juliodiez juliodiez requested review from wiktorn and ludoo and removed request for wiktorn and ludoo December 29, 2023 10:37
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, more comments to README.md than code itself :-)

blueprints/serverless/cloud-run-corporate/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-corporate/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-microservices/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-microservices/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-microservices/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-microservices/README.md Outdated Show resolved Hide resolved
blueprints/serverless/cloud-run-microservices/cloudrun.tf Outdated Show resolved Hide resolved
@juliodiez juliodiez merged commit ccc06fc into master Jan 5, 2024
13 checks passed
@juliodiez juliodiez deleted the jd/serverless-program branch January 5, 2024 21:03
@juliodiez juliodiez restored the jd/serverless-program branch January 5, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants