Extend cluster_autoscaling fields in gke-cluster-standard
#1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthonyhaussman
force-pushed
the
feat/tone/gke-cluster-standard_cluster_autoscaling_features
branch
from
069b090
to
9eca7a6
Compare
anthonyhaussman
force-pushed
the
feat/tone/gke-cluster-standard_cluster_autoscaling_features
branch
from
de7b7f3
to
040f309
Compare
juliocc
requested changes
Nov 9, 2023
juliocc
changed the title
cluster_autoscalingcluster_autoscaling fields in gke-cluster-standard
anthonyhaussman
force-pushed
the
feat/tone/gke-cluster-standard_cluster_autoscaling_features
branch
2 times, most recently
from
e2c030d
to
70fcfb7
Compare
juliocc
approved these changes
Nov 9, 2023
|
@anthonyhaussman ;can you fix the failing tests? |
…and `disk_type` to ensure only valid values are specified
auto-merge was automatically disabled
November 10, 2023 08:19
Head branch was pushed to by a user without write access
anthonyhaussman
force-pushed
the
feat/tone/gke-cluster-standard_cluster_autoscaling_features
branch
from
70fcfb7
to
a80fe68
Compare
@juliocc It should be good now 🙏 |
anthonyhaussman
force-pushed
the
feat/tone/gke-cluster-standard_cluster_autoscaling_features
branch
from
a80fe68
to
7b006d6
Compare
auto-merge was automatically disabled
November 10, 2023 10:45
Head branch was pushed to by a user without write access
anthonyhaussman
force-pushed
the
feat/tone/gke-cluster-standard_cluster_autoscaling_features
branch
from
7b006d6
to
e74e0ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(gke-cluster-standard): Add feature to setup cluster_autoscaling
autoscaling_profileifOPTIMIZE_UTILIZATIONis neededdisk_sizeanddisk_typemanagementandshielded_instance_configEach of these options is optional and set to their default value if not set.
feat(gke-cluster-standard): Add GPUs setup feature for
cluster_autoscalerAdd the possibility to setup
gpu_resourcesinto node auto-provisioning.Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py