gke-cluster-standard : Support upgrade_settings for node auto provisioner #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noony
force-pushed
the
gke-cluster-standard-upgrade-strat
branch
from
2915aa6
to
fe82867
Compare
ludoo
changed the title
ludoo
requested changes
Dec 7, 2023
ludoo
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies gke-cluster-standard list of changes :
Support Upgrade settings for Node Auto Provisionner
We can now define a strategy for NAP nodes upgrade SURGE / BLUE_GREEN and related configurations for each modes.
google_container_cluster documentation here
Set max_surge by default to 1 & max_unavailable 0 when NAP enabled
Currently node auto provisionner default for max_surge surge & max_unavailable are 0. This result in an invalid configuration for default settings in nap config.
When
upgrade_settingsis not defined we declare by default a max_surge 1 and max_unavailable 0 now.Checklist
I applicable, I acknowledge that I have:
terraform fmton all modified filestools/tfdoc.py