Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for subnet-level service network user grants to project module, improve docs #1907

Merged
merged 4 commits into from Dec 7, 2023
Merged

Add support for subnet-level service network user grants to project module, improve docs #1907

merged 4 commits into from Dec 7, 2023

Conversation

ludoo
Copy link
Collaborator

@ludoo ludoo commented Dec 7, 2023 •
edited

  • project factory: show how to manage service identity roles on the Shared VPC host project in the example
  • project module:
    • light refactor of Shared VPC IAM internal variables
    • reword the Shared VPC documentation in the README
    • add support for subnet-level compute.networkUser role grants for shared vpc service identities

@ludoo ludoo changed the title Improve project factory example Improve project factory example and project module docs Dec 7, 2023
@ludoo ludoo requested a review from wiktorn December 7, 2023 07:45
@ludoo ludoo changed the title Improve project factory example and project module docs Add support for subnet-level service network user grants to project module, improve docs Dec 7, 2023
@ludoo ludoo requested a review from juliocc December 7, 2023 08:49
@ludoo ludoo enabled auto-merge (squash) December 7, 2023 08:49
@ludoo ludoo removed the request for review from wiktorn December 7, 2023 08:55
@ludoo ludoo merged commit f548b65 into master Dec 7, 2023
13 checks passed
@ludoo ludoo deleted the ludo/pf-subnet-iam branch December 7, 2023 09:07
wiktorn
wiktorn approved these changes Dec 7, 2023
View reviewed changes
modules/project/README.md Show resolved Hide resolved
modules/project/README.md Show resolved Hide resolved
wiktorn added a commit that referenced this pull request Dec 7, 2023
@wiktorn
README fixes for #1907
84a15c4
wiktorn added a commit that referenced this pull request Dec 7, 2023
@wiktorn
Merge pull request #1908 from GoogleCloudPlatform/wiktorn_project_iam…
861df24 
…_subnet_readme

README fixes for #1907
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:blueprints on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ludoo @juliocc @wiktorn