Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net_lb_ext module e2e and example testing changes #1909

Merged
merged 3 commits into from Dec 8, 2023
Merged

net_lb_ext module e2e and example testing changes #1909

merged 3 commits into from Dec 8, 2023

Conversation

dibaskar-google
Copy link
Contributor

Checklist

I applicable, I acknowledge that I have:

  • [ X] Read the contributing guide
  • [ X] Ran terraform fmt on all modified files
  • [ X] Regenerated the relevant README.md files using tools/tfdoc.py
  • [ X] Made sure all relevant tests pass

@wiktorn
Copy link
Collaborator

wiktorn commented Dec 7, 2023

E2E Run

wiktorn
wiktorn requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Dinesh, all green. Can you just trim a bit inventories as per comment?

@dibaskar-google
Copy link
Contributor Author

Thank you Dinesh, all green. Can you just trim a bit inventories as per comment?

Thanks for the comments Wiktor. Inventories are trimmed now. Please let me know on any further changes.

wiktorn
wiktorn approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@wiktorn wiktorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@wiktorn wiktorn merged commit c65e242 into GoogleCloudPlatform:master Dec 8, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wiktorn wiktorn wiktorn approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dibaskar-google @wiktorn @ludoo