Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix always succeding test #1937

Merged
merged 2 commits into from Dec 21, 2023
Merged

Fix always succeding test #1937

merged 2 commits into from Dec 21, 2023

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Dec 19, 2023

Lack of modules declaration was preventing to run this test properly as there was no match on COUNT_TEST_RE

I'm getting close to rewrite # tftest parsing into something less regexp oriented.

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Copy link
Collaborator Author

wiktorn commented Dec 19, 2023

E2E Test run

@juliocc juliocc enabled auto-merge (squash) December 21, 2023 11:00
@juliocc juliocc merged commit 110fd79 into master Dec 21, 2023
10 of 11 checks passed
@juliocc juliocc deleted the fix_kms_test branch December 21, 2023 11:01
@ludoo ludoo added the on:tools New or changed tool label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliocc juliocc juliocc approved these changes

Assignees
No one assigned
Labels
on:tools New or changed tool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wiktorn @juliocc @ludoo