Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new resources in GCVE module, bump provider versions #1941

Merged
merged 5 commits into from Dec 21, 2023
Merged

Use new resources in GCVE module, bump provider versions #1941

merged 5 commits into from Dec 21, 2023

Conversation

LucaPrete
Copy link
Member

@LucaPrete LucaPrete commented Dec 20, 2023 •
edited

  • Allows users to create the new GCVE standard private cloud
  • Allows users to create multiple private clouds using the same module instantiation
  • Allows users to create peerings between the shared private cloud network and users' VPCs / other private vmware networks
  • Allows users to create additional clusters for each private cloud
  • Adds optionals/defaults to variables so users don't have to specify all of them for default configs
  • Bumps up the provider to the latest version (needed for new GCVE resources)
  • Fixes a gkehub test that now returns values in a slightly different format when using the new provider

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo approved these changes Dec 20, 2023
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is needed quickly for a customer as you shared, I trust you to have done the right thing :)

@LucaPrete LucaPrete requested a review from ludoo December 21, 2023 08:28
@LucaPrete LucaPrete force-pushed the new_vmware_engine_private_cloud branch from 6823f55 to 0276faa Compare December 21, 2023 10:10
@LucaPrete LucaPrete self-assigned this Dec 21, 2023
@ludoo ludoo changed the title Use new GCVE resources Use new resources in GCVE module, bump provider versions Dec 21, 2023
@LucaPrete LucaPrete enabled auto-merge (squash) December 21, 2023 13:10
@LucaPrete LucaPrete merged commit c412304 into master Dec 21, 2023
13 checks passed
@LucaPrete LucaPrete deleted the new_vmware_engine_private_cloud branch December 21, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

@eliamaldini eliamaldini Awaiting requested review from eliamaldini

Assignees

@LucaPrete LucaPrete

Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LucaPrete @ludoo