Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix to GCVE module readme #1946

Merged
merged 2 commits into from
Dec 21, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 3 additions & 7 deletions modules/gcve-private-cloud/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@

The module manages one or more Google Cloud VMWare Engine Private Clouds.

It also optionally creates:
- A VMWare engine network, shared betwee or it can work with an existing one. The module optionally creates peering connections to users' VPCs or other VMware engine networks.
It can either create a new VMWare engine network shared between the private clouds or it can use an existing one. The module also creates peering connections to users' VPCs or other VMware engine networks.

To understand the limits and to properly configure the vSphere/vSAN subnets CIDR range please refer to the [GCVE public documentation](https://cloud.google.com/vmware-engine/docs/quickstart-networking-requirements).

Be aware that the deployment of this module might require up to 2 hours depending on the selected private cloud target zone.
The deployment might require up to 2 hours, depending on the selected private cloud target zone.

<!-- BEGIN TOC -->
- [Limitations](#limitations)
Expand All @@ -20,7 +19,7 @@ Be aware that the deployment of this module might require up to 2 hours dependin

## Limitations

At the moment this module doesn't support the creation of stretched private clouds.
The module (and the underlying resource) still don't support the creation of stretched (regional) private clouds.

## Basic Private Cloud Creation

Expand All @@ -32,7 +31,6 @@ module "gcve-pc" {

vmw_network_peerings = {
transit-conn1 = {
name = "to-my-vpc"
peer_network = "projects/test-prj-gcve-01/global/networks/default"
}
}
Expand All @@ -59,7 +57,6 @@ module "gcve-pc" {

vmw_network_peerings = {
transit-conn1 = {
name = "to-my-vpc"
peer_network = "projects/test-prj-gcve-01/global/networks/default"
}
}
Expand Down Expand Up @@ -91,7 +88,6 @@ module "gcve-pc" {

vmw_network_peerings = {
transit-conn1 = {
name = "to-my-vpc"
peer_network = "projects/test-prj-gcve-01/global/networks/default"
}
}
Expand Down