Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-address end-to-end tests #1963

Merged
merged 5 commits into from Jan 6, 2024
Merged

net-address end-to-end tests #1963

merged 5 commits into from Jan 6, 2024

Conversation

wiktorn
Copy link
Collaborator

@wiktorn wiktorn commented Jan 6, 2024

  • add end-to-end tests for net-address
  • remove network_tier from internal address as it is unsupported
  • added subnetwork for external addresses as it is required to reserve external IPv6 address
  • removed unsupported reservation of static IPv6 address for Internal Load Balancer
  • removed unsupported PSC case with automatic assignment of IP address

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

@wiktorn
Remove tier for internall addresses
ce15ba8 
Error creating Address: googleapi: Error 400: Invalid value for field 'resource.networkTier': 'STANDARD'. An address with type INTERNAL cannot have a network tier., invalid
@wiktorn
Add end-to-end tests for net-address
45a83cc
@wiktorn
IPv6 address reservation not supported for ILB
5cf39c2 
Error creating Address: googleapi: Error 400: Invalid value for field 'resource.purpose': 'SHARED_LOADBALANCER_VIP'. Shared LoadBalancer VIP IPv6 address reservation is not supported., invalid
@wiktorn
Remove null address for PSC
ecc9d50 
null address results in following error:
Error creating GlobalAddress: googleapi: Error 400: Invalid value for field 'resource.address': ''. The field is not a valid IP address or does not match the given prefix length, invalid
@wiktorn
Add support for subnetwork for external addresses
70a10df 
For IPv6 it is necessary to provide subnetwork when reserving external
address.
ludoo
ludoo approved these changes Jan 6, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're on a roll Wiktor :)

@wiktorn wiktorn marked this pull request as ready for review January 6, 2024 13:01
@wiktorn
Copy link
Collaborator Author

wiktorn commented Jan 6, 2024

you're on a roll Wiktor :)

Got distracted with previous PR and couldn't stop myself 🤣

@wiktorn wiktorn merged commit 3982288 into master Jan 6, 2024
13 checks passed
@wiktorn wiktorn deleted the wiktorn-e2e-net-address branch January 6, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wiktorn @ludoo