Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Cross-region internal application load balancer module #1981

Merged
merged 1 commit into from Jan 16, 2024
Merged

Added Cross-region internal application load balancer module #1981

merged 1 commit into from Jan 16, 2024

Conversation

apichick
Copy link
Collaborator

Checklist

I applicable, I acknowledge that I have:

  • Read the contributing guide
  • Ran terraform fmt on all modified files
  • Regenerated the relevant README.md files using tools/tfdoc.py
  • Made sure all relevant tests pass

ludoo
ludoo reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to also update the top-level and module-level READMEs. :)

ludoo
ludoo reviewed Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not up to date with the latest on load balancers, but how is this different from the L7 ILB in terms of resources? Is this somethign that can be done via variables there, or does it really need a new module?

ludoo
ludoo approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@ludoo ludoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to add to the top-level READMES :)

@apichick
Copy link
Collaborator Author

added links to READMEs.

@apichick apichick merged commit e5de2ed into GoogleCloudPlatform:master Jan 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludoo ludoo ludoo approved these changes

Assignees
No one assigned
Labels
on:documentation on:modules
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@apichick @ludoo